ShowKeyPlus

Cliff S said:

Just got the update this morning.

Thanx Cliff

BTW I tried to figure out the Windows logic on how it handles the accent highlght (see below) - sometimes it's the actual accent color other times it's a variant. I just went with a gradient in the end.

Superfly said:

Thanx Cliff

BTW I tried to figure out the Windows logic on how it handles the accent highlght (see below) - sometimes it's the actual accent color other times it's a variant. I just went with a gradient in the end.

It looks like it's using too much transparency.
Can you adjust the opacity?

Cliff S said:

It looks like it's using too much transparency.
Can you adjust the opacity?

Yep, that's what I'm doing but changing the opacity just gives different shades - the pic about seems to use a completely different RGB

I noticed that Windows will use a default color if you have an accent color it deems not being able to show up well, like here:

Bree said:

The 'problem' machine I've been using for your testing has just updated to 1.1.12.0 and I'm please to report it no longer has a problem.

Excellent! - lets hope the world-wide crash reports reduce as well...

@Cliff S

FWIW.. this code says if light theme no opacity otherwise 0.5 opacity.

Code:

            public Brush AccentBright
            {
                get
                {
   
                    Uri newWindowsTheme = Application.Current.Resources.MergedDictionaries[0].Source;
                    float convert = (newWindowsTheme.ToString() == $"/Themes/Light.xaml") ? (float) 0 : (float) 0.5;


                    Color newColour = (Color)ColorConverter.ConvertFromString(Accent);

                    SolidColorBrush brush = new SolidColorBrush(ChangeColorBrightness(newColour, convert));
                    return brush;
                }
            }

I can change the latter (which only applies to Dark theme by definition) and it's either invisible ( opacity =0 ) with the Accent background or too light (opacity 1) as opposed to bright -- which is what we are after

Don't know if this will help, I'm not a coder, but when setting up and playing with the JSON file for Windows Terminal preview, I found for best effect setting:
"acrylicOpacity" : 0.10000000149011612
and
"backgroundImageOpacity" : 1.0
preview

OK looks promising - I get this with the 0.10000000149011612 setting

Superfly said:

OK looks promising - I get this with the 0.10000000149011612 setting

Just keep raising & lowering the last few digits until you get the effect you are searching for(1612)

The other thing I must mention is that the alpha value is static ('color.A' below) - is that the problem and should it be changed? and if so to what?

Code:

            public static Color ChangeColorBrightness(Color color, float correctionFactor)
            {
                float red = (float)color.R;
                float green = (float)color.G;
                float blue = (float)color.B;

                if (correctionFactor < 0)
                {
                    correctionFactor = 1 + correctionFactor;
                    red *= correctionFactor;
                    green *= correctionFactor;
                    blue *= correctionFactor;
                }
                else
                {
                    red = (255 - red) * correctionFactor + red;
                    green = (255 - green) * correctionFactor + green;
                    blue = (255 - blue) * correctionFactor + blue;
                }
        
                return Color.FromArgb(color.A, (byte)red, (byte)green, (byte)blue);